Conversation
…updated referenced workflow inputs, uses PR branch ref
jo-basevi
had a problem deploying
to
Gadi Initial Checksum
GitHub Actions
Failure
CodeGat
requested review from
Copilot and
jo-basevi
and removed request for
blimlim
There was a problem hiding this comment.
Pull Request Overview
This PR updates the workflow to allow users to specify custom pytest markers for generating initial checksums. Key changes include:
- Adding a new, optional input "test-markers" with a default value.
- Adding a new optional input "committed-checksum-create-release" for tag-based GitHub Releases.
- Updating the generate-checksums job to conditionally run and pass the new test markers input.
jo-basevi
approved these changes
Mar 28, 2025
Contributor
jo-basevi
left a comment
jo-basevi
left a comment
There was a problem hiding this comment.
Looks good - will need a follow-up PR with updating model-config-tests workflow to @main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References ACCESS-NRI/model-config-tests#147
Background
The 'generate initial checksums' workflow used to assume that the pytest markers were always
checksum. The markers had changed, which led to the workflow erroneously succeeding without testing anything.Instead, make the pytest markers for initial checksums settable by the user, giving a sensible default of
repro_historicalrather than hardcoding it.The PR
test-markersthat defaults torepro_historical.model-config-testsworkflow entrypoint.